Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue is that the downloadSass task wasn't properly configured for Gradle's incremental builds and caching. Even though overwrite(false) was set, the task was still running the download every time because:
I've updated the SassGradlePlugin.java to:
task.onlyIf(task -> !task.getDest().exists())
to thedownloadSass
task, ensuring it only runs if the archive file doesn't exist.task.getOutputs().cacheIf(task -> true)
for bothdownloadSass
andinstallSass
tasks, allowing Gradle to cache and reuse the outputs.This should prevent unnecessary downloads on subsequent builds, as the tasks will now be up-to-date when the files exist and can leverage build caching.
Test it by running your build again—the download should be skipped if the Sass archive is already present.